Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openrw: 2017-09-17 -> 2019-10-26 #72037

Merged
merged 2 commits into from
Oct 29, 2019
Merged

openrw: 2017-09-17 -> 2019-10-26 #72037

merged 2 commits into from
Oct 29, 2019
+11 −7

Conversation

kragniz
Copy link
Member

@kragniz kragniz commented Oct 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 26, 2019
@risicle
Copy link
Contributor

risicle commented Oct 27, 2019

To get this building on macos you need to give it the OpenAL and Cocoa frameworks by adding ++ (stdenv.lib.optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [ OpenAL Cocoa ])) to the buildInputs. WFM on macos 10.13.

@veprbl veprbl force-pushed the openrw-2019-10-26 branch from 42828d9 to ddbf53b Compare October 29, 2019 18:09
@veprbl
Copy link
Member

veprbl commented Oct 29, 2019

@GrahamcOfBorg build openrw

@veprbl veprbl merged commit 3328244 into NixOS:master Oct 29, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 29, 2019
@veprbl @dtzWill
Merge pull request NixOS#72037 from kragniz/openrw-2019-10-26
afd2a1a 
openrw: 2017-09-17 -> 2019-10-26
(cherry picked from commit 3328244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kragniz @risicle @veprbl