youtube-dl: 2019.10.22 -> 2019.10.29 #72203
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
bluescreen303,
Fuuzetsu,
Phreedom,
fpletz and
AndersonTorres
|
@GrahamcOfBorg build youtube-dl |
jonringer
added
the
9.needs: port to stable
jonringer
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
nix-review passes on NixOS (2 broken on master)
diff LGTM
most executables seem to work
[29 built (2 failed), 72 copied (237.3 MiB), 51.2 MiB DL]
error: build of '/nix/store/swijvi1mr386lca4bdk6w7fad71g3jkk-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72203
2 package failed to build:
deepin.dde-file-manager plex-media-player
27 package were build:
bomi catt celluloid curseradio deepin.deepin-movie-reborn kodi-cli lollypop minitube mopidy-youtube mpc-qt mpv mpv-with-scripts persepolis python27Packages.pafy python27Packages.youtube-dl python27Packages.youtube-dl-light python37Packages.mps-youtube python37Packages.mpv python37Packages.pafy youtube-dl youtube-dl-light python38Packages.mps-youtube python38Packages.mpv python38Packages.pafy python38Packages.youtube-dl python38Packages.youtube-dl-light ytcc
|
Was this backported? |
|
no EDIT: or at the very least, i did not backport it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
youtube-dlto the latest release.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @bluescreen303 @Phreedom @AndersonTorres @Fuuzetsu @fpletz @Enzime