Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbacktrace: init at 2018-06-05 #72161

Merged
merged 2 commits into from Sep 24, 2020
Merged

libbacktrace: init at 2018-06-05 #72161

merged 2 commits into from Sep 24, 2020

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Oct 28, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@Twey
Copy link
Contributor Author

Twey commented Oct 28, 2019 •
edited

Date-versioning is because, even though this is version 1.0, the README explicitly commits to never changing version:

This is version 1.0.
It is likely that this will always be version 1.0.

and indeed several changes have been made to ‘version 1.0’, so the official version number is rather meaningless.

vyp
vyp approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@vyp vyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Twey
Copy link
Contributor Author

Twey commented Jun 16, 2020

Addressed comment and updated.

@Twey
Copy link
Contributor Author

Twey commented Sep 11, 2020

Bump!

@ryantm
Copy link
Member

ryantm commented Sep 24, 2020

Result of nixpkgs-review pr 72161 1

1 package built:
- libbacktrace

@ryantm ryantm merged commit d6d1c12 into NixOS:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Twey @ryantm @vyp