Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop: add libappindicator-gtk3 #72151

Merged
merged 1 commit into from Oct 30, 2019

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Oct 28, 2019

Motivation for this change

electron needs libappindicator-gtk3 library so that it can draw indicators in gnome.

Things done

added indicator and verified it worked on my machine. im also interested in backporting this to 19.09

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

mmahut commented Oct 29, 2019

@GrahamcOfBorg build signal-desktop

@bjornfor bjornfor merged commit 17da09c into NixOS:master Oct 30, 2019
@mogorman mogorman deleted the signal-desktop branch October 31, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants