diffoscope: add dependency on python xattr package #72239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsam
reviewed
Oct 30, 2019
| @@ -35,7 +35,7 @@ python3Packages.buildPythonApplication rec { | |||
| # | |||
| # Still missing these tools: abootimg docx2txt dumpxsb enjarify js-beautify lipo oggDump otool procyon-decompiler Rscript wasm2wat zipnode | |||
| # Also these libraries: python3-guestfs | |||
| pythonPath = with python3Packages; [ debian libarchive-c python_magic tlsh rpm ] ++ [ | |||
| pythonPath = with python3Packages; [ debian libarchive-c python_magic tlsh rpm xattr ] ++ [ | |||
There was a problem hiding this comment.
I think it should be pyxattr
Suggested change
| pythonPath = with python3Packages; [ debian libarchive-c python_magic tlsh rpm xattr ] ++ [ | |
| pythonPath = with python3Packages; [ debian libarchive-c python_magic tlsh rpm pyxattr ] ++ [ |
There was a problem hiding this comment.
I'm not quite clear on the difference but I can confirm it works with pyxattr as well, updated.
To be able to diffoscope 2 directories
raboof
force-pushed
the
diffoscope-xattrs
branch
from
0ed54b0
to
ea2c7ea
Compare
|
Thank you @raboof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To be able to diffoscope 2 directories
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @dezgeg