Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Po4a: fix build #72170

Merged
merged 1 commit into from Oct 28, 2019
Merged

perlPackages.Po4a: fix build #72170

merged 1 commit into from Oct 28, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 28, 2019

Motivation for this change

Fixes #71296

Term::ReadKey is an optional dependency. From upstream:

This module is used to retrieve the terminal's line width.
If it is not present, the line width can be specified with the COLUMN environment variable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
perlPackages.Po4a: fix build
5e7bf85 
Fixes NixOS#71296

Term::ReadKey is an optional dependency. From upstream:
> This module is used to retrieve the terminal's line width.
> If it is not present, the line width can be specified with the COLUMN environment variable.
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 28, 2019

I couldn't figure out what changed with Term::ReadKey or our Perl env that cause Po4a build to get stuck... But without this optional dep the build goes fine.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 28, 2019

@GrahamcOfBorg build perl528Packages.Po4a perl530Packages.Po4a apt sssd

@c0bw3b c0bw3b merged commit 97a5c41 into NixOS:master Oct 28, 2019
@c0bw3b c0bw3b deleted the fix/po4a branch October 28, 2019 16:27
@Gonzih
Copy link
Contributor

Gonzih commented Oct 28, 2019

Can this be backported into 19.09 release?

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 28, 2019

Indeed, I will fix this on the release too.

c0bw3b added a commit that referenced this pull request Oct 28, 2019
@c0bw3b
perlPackages.Po4a: fix build
481cff2 
Backport of #72170
Related issue: #71296 (Po4a build get stuck in a loop)

Term::ReadKey is an optional dependency. From upstream:
> This module is used to retrieve the terminal's line width.
> If it is not present, the line width can be specified with the COLUMN environment variable.
c0bw3b added a commit that referenced this pull request Oct 28, 2019
@c0bw3b
perlPackages.Po4a: fix build
b6cfdce 
Backport of #72170
Related issue: #71296 (Po4a build get stuck in a loop)

Term::ReadKey is an optional dependency. From upstream:
> This module is used to retrieve the terminal's line width.
> If it is not present, the line width can be specified with the COLUMN environment variable.
@Gonzih
Copy link
Contributor

Gonzih commented Oct 28, 2019

@c0bw3b thank you so much! ❤️

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 20, 2019
@c0bw3b @dtzWill
perlPackages.Po4a: fix build (NixOS#72170)
5b22a55 
Fixes NixOS#71296 (Po4a build get stuck in a loop)

Term::ReadKey is an optional dependency. From upstream:
> This module is used to retrieve the terminal's line width.
> If it is not present, the line width can be specified with the COLUMN environment variable.

(cherry picked from commit 97a5c41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

po4a build stuck in busyloop with services.sssd.enable
2 participants
@c0bw3b @Gonzih