Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocamlearlybird: init at 0.1.5; ocamlPackages.angstrom: 0.10.0 -> 0.12.1 #72171

Merged
merged 5 commits into from Oct 29, 2019
Merged

ocamlPackages.ocamlearlybird: init at 0.1.5; ocamlPackages.angstrom: 0.10.0 -> 0.12.1 #72171

merged 5 commits into from Oct 29, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 28, 2019 •
edited

Motivation for this change
  • ocamlPackages.angstrom: 0.10.0 -> 0.12.1
  • ocamlPackages.angstrom-async: init at 0.12.1
  • ocamlPackages.angstrom-lwt-unix: init at 0.12.1
  • ocamlPackages.angstrom-unix: init at 0.12.1
  • ocamlPackages.ocamlearlybird: init at 0.1.5
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vbgl
vbgl requested changes Oct 29, 2019
View reviewed changes
pkgs/top-level/ocaml-packages.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/ocamlearlybird/default.nix Outdated Show resolved Hide resolved
@romildo romildo changed the title ocamlPackages.ocamlearlybird: init at 0.1.4; ocamlPackages.angstrom: 0.10.0 -> 0.12.1 ocamlPackages.ocamlearlybird: init at 0.1.5; ocamlPackages.angstrom: 0.10.0 -> 0.12.1 Oct 29, 2019
@vbgl
Copy link
Contributor

vbgl commented Oct 29, 2019

@GrahamcOfBorg build ocamlPackages.earlybird

vbgl
vbgl approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vbgl vbgl merged commit 5a4e67a into NixOS:master Oct 29, 2019
@vbgl
Copy link
Contributor

vbgl commented Oct 29, 2019

Does the version of OCaml that is used to compile the ocamlearlybird binary program matter?

If it does not matter, then the earlybird package may better stay out of the ocamlPackages set.

@romildo romildo deleted the upd.ocamlearlybird branch March 27, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @vbgl