nats: update versions, rename gnatsd, add libnats #72206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoughtpolice
force-pushed
the
nixpkgs/nats-update
branch
from
88254c3
to
9eaa49e
Compare
|
@GrahamcOfBorg eval |
Signed-off-by: Austin Seipp <aseipp@pobox.com>
Signed-off-by: Austin Seipp <aseipp@pobox.com>
Signed-off-by: Austin Seipp <aseipp@pobox.com>
thoughtpolice
force-pushed
the
nixpkgs/nats-update
branch
from
9eaa49e
to
5a3212e
Compare
| src = fetchFromGitHub { | ||
| owner = "nats-io"; | ||
| repo = "nats.c"; | ||
| rev = "refs/tags/v${version}"; |
There was a problem hiding this comment.
How does this work? fetchFromGitHub will use fetchzip if you didn't use fetchSubmodules, so this would make it fetch "https://github.com/nats-io/nats.c/archive/refs/tags/v${version}.tar.gz" not https://github.com/nats-io/nats.c/archive/v2.1.0.tar.gz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This updates
nats-server(previously known asgnatsd),nats-streaming-server, and adds thenats.clibrary as well.Things done
sandboxinnix.confon non-NixOS)