Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

melonDS: init at 0.8.3 #72209

Closed
wants to merge 1 commit into from
Closed

melonDS: init at 0.8.3 #72209

wants to merge 1 commit into from

Conversation

artemist
Copy link
Member

Motivation for this change

melonDS is a useful DS emulator. It's still a WIP, but it is compatible with some games. I used the release version, although the git version has better compatibility, I'll update this when the next version comes out

Things done

Create a new package for the melonDS emulator

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

That's me

artemist
artemist commented Oct 29, 2019
View reviewed changes
pkgs/misc/emulators/melonDS/default.nix
buildInputs = [ SDL2 gtk3 curl libpcap ];

postInstall = ''
install -Dm644 romlist.bin "$out/share/melonDS/romlist.bin"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is needed for saving to work right, but there's currently no way to set its path without adding a patch. I include it here so that users can symlink it into their directory along with the other binaries required.

Copy link
Member

@vyp vyp Oct 29, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nixos.org/nixpkgs/manual/#sec-patches

You can include a nixpkgs-specific patch in this directory too if you think that would be useful/better for users. If it's not nixpkgs specific then it's preferred you submit the patch to upstream if possible. Because keep in mind as maintainer you would be expected to maintain any patch files you include.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to work on this upstream when I have time. Currently upstream makes a lot of assumptions which would make a patch a bit unclean.

vyp
vyp suggested changes Oct 29, 2019
View reviewed changes
pkgs/misc/emulators/melonDS/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/melonDS/default.nix Outdated Show resolved Hide resolved
@vyp
Copy link
Member

vyp commented Oct 29, 2019 •
edited

I'm not really sure why the eval check fails. 😕 Feel free to revert d94de75 if no one else looks at this, sorry about that.

vyp
vyp reviewed Oct 29, 2019
View reviewed changes
pkgs/misc/emulators/melonDS/default.nix Outdated
@@ -0,0 +1,29 @@
{ stdenv, fetchFromGitHub, cmake, pkgconfig, SDL2, gtk3, curl, libpcap }:

stdenv.mkDerivation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv.mkDerivation {
stdenv.mkDerivation rec {

Forgot you need this here.

@artemist
Copy link
Member Author

I never actually figured out what rec did before! I fixed that and squashed.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@benley benley mentioned this pull request Jun 16, 2020
Merged
10 tasks
@artemist artemist closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp requested changes

@lopsided98 lopsided98 lopsided98 left review comments

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artemist @vyp @lopsided98