Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode extensions #72208

Merged
merged 5 commits into from Nov 8, 2019
Merged

Vscode extensions #72208

merged 5 commits into from Nov 8, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Wanted to add a few more vscode extensions

you can test with

$ nix-shell --pure -p "with import ./. {}; vscode-with-extensions.override {vscodeExtensions = with vscode-extensions; [ ms-kubernetes-tools.vscode-kubernetes-tools redhat.vscode-yaml ms-azuretools.vscode-docker ms-vscode.Go vscodevim.vim ];}"
$ code

###### Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
   - [x] NixOS
   - [ ] macOS
   - [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

###### Notify maintainers

cc @

@domenkozar domenkozar merged commit c62815d into NixOS:master Nov 8, 2019
@jonringer jonringer deleted the vscode-extensions branch November 8, 2019 15:38
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
Vscode extensions

(cherry picked from commit c62815d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants