Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nasty Schematic vs PCB bug in revC1 - 1.2V and 3.3V regulators are swapped #170

Closed
TomKeddie opened this issue Oct 29, 2019 · 6 comments
Closed

Nasty Schematic vs PCB bug in revC1 - 1.2V and 3.3V regulators are swapped #170

TomKeddie opened this issue Oct 29, 2019 · 6 comments

Comments

@TomKeddie
Copy link
Contributor

TomKeddie commented Oct 29, 2019 •
edited
Loading

I really want this to be some kind of mistake I've made but I'm fairly sure the pcb does not match the schematic. I believe the part numbers for U8 and U36 are swapped in the PCB file, the 1.2V regulator (TLV73312PQDRVRQ1) is shown as U8 driving the 3.3V bus.

This also affects the bom generated by the interactive bom generator. I'm hoping my board is ok but once I saw the 1.2V rail rise to 1.4V and shutdown I had a sinking feeling.

You can also see this in the text of the kicad files (thank you kicad for using plain text). The schematic does not match the pcb (github won't view the file).

image
@marcan
Copy link
Member

marcan commented Oct 29, 2019

Ugh. Yeah, we found this, and fixed it, but evidently I forgot about regenerating the fabrication outputs (and updating the PCB) with the fixed schematic data.

I'll do that as soon as I get home. Sorry that you had to stumble upon this the hard way.

@TomKeddie
Copy link
Contributor Author

TomKeddie commented Oct 29, 2019 •
edited
Loading

Thanks I figured someone must have seen this I guess I should have been working off the branch not master. Seems like that's the only PR that needs merging to master.

Sorry, something went wrong.

@marcan
Copy link
Member

marcan commented Oct 29, 2019

Those commits should be in master too, unless I did something horribly wrong. What I just didn't do yet is propagate the change to the other files.

Sorry, something went wrong.

@TomKeddie
Copy link
Contributor Author

TomKeddie commented Oct 29, 2019 •
edited
Loading

I test generated a PR from revC1 to master, the schematic file changes were the only ones that came up not merged. (edit schematic not pcb, so yes pcb needs to be updated)

Sorry, something went wrong.

@TomKeddie
Copy link
Contributor Author

TomKeddie commented Oct 29, 2019 •
edited
Loading

I should add that I have absolutely no ill feelings about this. I'm in the wild west of hardware and here be dragons. I built two boards knowing that the process might not be smooth, I now need to find the shorts on my other board.

@marcan
Copy link
Member

marcan commented Oct 30, 2019

Should be fixed in dc3e083 (branch) and b436530 (master). Sorry again for leaving this pending so long :(

@marcan marcan closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcan @TomKeddie