Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bslizr: init at 1.2.0 #72256

Merged
merged 1 commit into from
Oct 30, 2019
Merged

bslizr: init at 1.2.0 #72256

merged 1 commit into from
Oct 30, 2019
+30 −0

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 29, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@magnetophon magnetophon mentioned this pull request Oct 29, 2019
Closed
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 29, 2019
@marsam marsam merged commit 57c9229 into NixOS:master Oct 30, 2019
@marsam
Copy link
Contributor

marsam commented Oct 30, 2019

Thanks!

@magnetophon
Copy link
Member Author

@marsam Thank you!
#72267 is the same code for two more repo's, so you might wanna have a look there as well.
Of course I put the platform in as soon as you reminded me here!

@magnetophon magnetophon deleted the bslizr branch October 30, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @marsam