Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in CONTRIBUTING.md #72183

Merged
merged 2 commits into from Oct 28, 2019
Merged

Fix link in CONTRIBUTING.md #72183

merged 2 commits into from Oct 28, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Oct 28, 2019

Motivation for this change

broken link

might be also the case in other places

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vcunat vcunat added 9.needs: port to stable A PR needs a backport to the stable release. and removed 6.topic: policy discussion labels Oct 28, 2019
@vcunat
Copy link
Member

vcunat commented Oct 28, 2019 •
edited

I only found one other occurrence in this repo (see commit). I haven't looked into other names that might've gotten changed at the same time.

@FRidh FRidh merged commit 3c5f5b1 into NixOS:master Oct 28, 2019
@FRidh
Copy link
Member

FRidh commented Oct 28, 2019

Thank you. I did not think about link references when I made my changes in the manual.

@davidak davidak deleted the patch-2 branch October 28, 2019 18:54
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidak @vcunat @FRidh