Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ripasso-cursive: unstable-2019-08-27 -> 0.3.0 #72188

Merged
merged 1 commit into from Dec 7, 2019
Merged

ripasso-cursive: unstable-2019-08-27 -> 0.3.0 #72188

merged 1 commit into from Dec 7, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 28, 2019

Motivation for this change

Updates ripasso-cursive to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexanderkjall
Copy link
Contributor

CC @etu

@etu
Copy link
Contributor

etu commented Nov 11, 2019

@GrahamcOfBorg build ripasso-cursive

@etu
Copy link
Contributor

etu commented Nov 11, 2019

Curious, I'm getting the following build failure locally (NixOS x86_64):

running 2 tests
test pass::test::get_password_dir_no_env ... ok
test pass::test::get_password_dir ... FAILED

failures:

---- pass::test::get_password_dir stdout ----
thread 'pass::test::get_password_dir' panicked at 'called `Result::unwrap()` on an `Err` value: Generic("failed to locate password directory")', src/libcore/result.rs:1084:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.


failures:
    pass::test::get_password_dir

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'
builder for '/nix/store/rgdqspr9wm7z537a4536jfz0vwr5q4sd-ripasso-cursive-0.2.1.drv' failed with exit code 101
error: build of '/nix/store/rgdqspr9wm7z537a4536jfz0vwr5q4sd-ripasso-cursive-0.2.1.drv' failed

But it seems to work on the build bot. The bot managed to build it on both aarch64 and x86_64 linux. So that's fine I guess?

We also have darwin as a new platform, where the build seems to fail. You have the full log here: https://logs.nix.ci/?key=nixos/nixpkgs.72188&attempt_id=abcfb437-2b42-4c2a-8f14-2a6465364206

@stigtsp
Copy link
Member Author

stigtsp commented Nov 11, 2019

We also have darwin as a new platform, where the build seems to fail. You have the full log here: https://logs.nix.ci/?key=nixos/nixpkgs.72188&attempt_id=abcfb437-2b42-4c2a-8f14-2a6465364206

@alexanderkjall Looks like a problem setting up the test environment? I'll be able to have a look on Darwin tomorrow.

@stigtsp
Copy link
Member Author

stigtsp commented Nov 12, 2019

I'll be able to have a look on Darwin tomorrow.

Stuck in the snow ☃️

@stigtsp
Copy link
Member Author

stigtsp commented Dec 2, 2019 •
edited

Thx to @tssm for fixing MacOS build.

Pls don't merge yet. 0.3.0 is out, will update for this new version.

Updated to latest release: 0.3.0

@stigtsp @tssm
ripasso-cursive: unstable-2019-08-27 -> 0.3.0
2523a7f 
- updated to 0.3.0
- builds man page
- add macOS support (@tssm)

Co-authored-by: Tae Sandoval <tssm@users.noreply.github.com>
@stigtsp stigtsp force-pushed the package/ripasso-cursive-0.2.1 branch from e802b4a to 2523a7f Compare December 2, 2019 12:43
@stigtsp stigtsp changed the title ripasso-cursive: unstable-2019-08-27 -> 0.2.1 ripasso-cursive: unstable-2019-08-27 -> 0.3.0 Dec 2, 2019
@stigtsp
Copy link
Member Author

stigtsp commented Dec 2, 2019 •
edited

note: ripasso-cursive builds fine on macOS with nix-build -A ripasso-cursive.

but nix-review fails on macOS. Maybe due to stdenv-darwin/setup not having gnutar in the PATH:

UPDATE: This appears to be caused by nix-review using nix-build --option build-use-sandbox true, which might not be supported on macOS.

$ nix-shell -p nix-review --run "nix-review pr 72188"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/72188/head:refs/nix-review/1
$ git worktree add /Users/user/.cache/nix-review/pr-72188-1/nixpkgs 8d0263863a806af0a6bb66b09d849243e65e6a15
Preparing worktree (detached HEAD 8d0263863a8)
Updating files: 100% (20386/20386), done.
HEAD is now at 8d0263863a8 Merge pull request #74824 from jojosch/dbeaver_6.3.0
$ git merge --no-commit 2523a7f377d8d7fcd09c5e861b6346e162556aed
Auto-merging pkgs/top-level/all-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /Users/user/.cache/nix-review/pr-72188-1/build.nix
builder for '/nix/store/dd133ml884435n7byw2rgzr71f9gfgyn-source.drv' failed with exit code 1; last 10 log lines:
                                   Dload  Upload   Total   Spent    Left  Speed
  100   129    0   129    0     0    360      0 --:--:-- --:--:-- --:--:--   360
  100  115k    0  115k    0     0   114k      0 --:--:--  0:00:01 --:--:--  210k
  unpacking source archive /private/var/folders/g1/y968ywwx2s9c016g26_dbpcm0000gn/T/nix-build-source.drv-0/release-0.3.0.tar.gz
  dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
    Referenced from: /nix/store/rrg9ab9wnnd0n9hkl55miah824vv1xjq-gettext-0.20.1/lib/libintl.8.dylib
    Reason: no suitable image found.  Did find:
   /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
  /nix/store/ggw6axmdf4bg17z2pc2zaxpd1fjhsy3d-stdenv-darwin/setup: line 836:   687 Abort trap: 6           tar xf "$fn"
  do not know how to unpack source archive /private/var/folders/g1/y968ywwx2s9c016g26_dbpcm0000gn/T/nix-build-source.drv-0/release-0.3.0.tar.gz
cannot build derivation '/nix/store/zz9jv5havdgas57g382qlmh8drdqwndb-ripasso-cursive-0.3.0-vendor.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vdh81mx9is33q034kpjry94c0nqgzaxw-ripasso-cursive-0.3.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gqxyd9jpc5lslcyxv22c8cx1igfvjffn-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/gqxyd9jpc5lslcyxv22c8cx1igfvjffn-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72188
1 package failed to build:
ripasso-cursive

[0.0 MiB DL]
error: build log of '/nix/store/vdh81mx9is33q034kpjry94c0nqgzaxw-ripasso-cursive-0.3.0.drv' is not available
$ nix-shell /Users/user/.cache/nix-review/pr-72188-1/shell.nix

@stigtsp
Copy link
Member Author

stigtsp commented Dec 3, 2019 •
edited

Adding the following to nix.conf fixed the nix-review problem on darwin, which was caused by sandboxing. Thx to #nix-darwin

https://gist.github.com/LnL7/1cfca66d17eba1f9936175926bf39de8

sandbox = true
extra-sandbox-paths = /System/Library/Frameworks /System/Library/PrivateFrameworks /usr/lib /private/tmp /private/var/tmp /usr/bin/env

On darwin:

Result of nix-review pr 72188 1

1 package were built:
  • ripasso-cursive

@etu
Copy link
Contributor

etu commented Dec 7, 2019

@GrahamcOfBorg build ripasso-cursive

@etu etu merged commit 41beae8 into NixOS:master Dec 7, 2019
@stigtsp stigtsp deleted the package/ripasso-cursive-0.2.1 branch December 7, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @alexanderkjall @etu