Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/netdata: add which to path #72187

Merged
merged 1 commit into from Nov 3, 2019
Merged

nixos/netdata: add which to path #72187

merged 1 commit into from Nov 3, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 28, 2019 •
edited

Motivation for this change

Fixed this bug - #72163

Please recheck this variant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

rnhmjoj
rnhmjoj approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also nixosTests.netdata passes.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/64

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2019

@GrahamcOfBorg test netdata

@c0bw3b c0bw3b merged commit 266d3dd into NixOS:master Nov 3, 2019
@Izorkin Izorkin deleted the netdata-fix branch November 3, 2019 13:44
@marsam marsam mentioned this pull request Nov 6, 2019
Closed
@NomisIV NomisIV mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @nixos-discourse @c0bw3b @rnhmjoj