Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmpt123: 0.4.1 -> 0.4.9, fixing CVE-2019-17113 #71080

Merged
merged 1 commit into from Oct 28, 2019
Merged

openmpt123: 0.4.1 -> 0.4.9, fixing CVE-2019-17113 #71080

merged 1 commit into from Oct 28, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 13, 2019 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-17113

I'm unsure whether this package is actually vulnerable - CVE-2019-17113 is a vulnerability in the c interface libopenmpt, which this package doesn't expose intentionally. Though I suspect that the package actually does expose it and it would be possible for another package to use it as a functioning libopenmpt. Either way, best to be sure & bump it anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from a user October 13, 2019 12:11
ghost
ghost approved these changes Oct 13, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updates are always good. Works for me, thanks!

@multun
Copy link
Member

multun commented Oct 18, 2019

Works for me as well !

@ghost ghost mentioned this pull request Oct 26, 2019
Merged
10 tasks
@risicle
Copy link
Contributor Author

risicle commented Oct 27, 2019

@GrahamcOfBorg build openmpt123

@ckauhaus ckauhaus merged commit 641b853 into NixOS:master Oct 28, 2019
@ckauhaus
Copy link
Contributor

ofBorg seems to be a bit overloaded, but managed to build it locally on my NixOS box.

@risicle risicle mentioned this pull request Oct 28, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @multun @ckauhaus @veprbl