Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-subcopy: init at 0.1.0 #72153

Closed
wants to merge 1 commit into from
Closed

git-subcopy: init at 0.1.0 #72153

wants to merge 1 commit into from

Conversation

jD91mZM2
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Jan 7, 2020

Not sure, but I feel like a bump is in order?

@doronbehar
Copy link
Contributor

Not sure, but I feel like a bump is in order?

That doesn't help as no one is "watching" this repo because of the enormous amount of PRs.

@doronbehar
Copy link
Contributor

Also, you should use "init at" and not "new at" in your PR title, as explained in CONTRIBUTING.md.

doronbehar
doronbehar reviewed May 23, 2020
View reviewed changes
pkgs/development/tools/git-subcopy/default.nix
version = "0.1.0";

package = (callPackage ./Cargo.nix {}).rootCrate.build;
in package.overrideAttrs (attrs: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you generate that Cargo.nix? And why not use rustPlatform?

@jD91mZM2
Copy link
Member Author

I no longer care about this project, let's not put it in nixpkgs :)

@jD91mZM2 jD91mZM2 closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jD91mZM2 @doronbehar