Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: only build docs on linux #72269

Merged
merged 1 commit into from Oct 29, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 29, 2019

Motivation for this change

cc @jtojnar @FRidh. This will fix the macos build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roosemberth
Copy link
Contributor

The current attribute gtk3 on the 19.09 channel does not generate the devdoc output (so I can't compare wrt this).

I was able to build this on linux, it generates the devdoc output with files with exactly the same hashes as HEAD^

@worldofpeace worldofpeace added this to Ready in Staging Oct 29, 2019
@worldofpeace worldofpeace merged commit 374e6e9 into NixOS:staging-next Oct 29, 2019
@worldofpeace worldofpeace moved this from Ready to Merged in Staging Oct 29, 2019
@jtojnar jtojnar deleted the gtk-no-gtk-doc-macos branch March 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants