Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sndio: fix build on darwin #72033

Merged
merged 1 commit into from Oct 28, 2019
Merged

sndio: fix build on darwin #72033

merged 1 commit into from Oct 28, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Chiiruno

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 26, 2019
@ofborg ofborg bot requested a review from Chiiruno October 26, 2019 16:47
@Chiiruno
Copy link
Contributor

I'm not using nix on Darwin, am I even able to test and approve this?

@risicle
Copy link
Contributor

risicle commented Oct 27, 2019 •
edited

macos 10.13:

builder for '/nix/store/1q8jx8qvhxbnympyzshhbqf3xxd4cncb-python3.7-mpv-0.3.9.drv' failed with exit code 1; last 10 log lines:
  running install tests
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/private/tmp/nix-build-python3.7-mpv-0.3.9.drv-0/source/mpv.py", line 46, in <module>
      backend = CDLL(sofile)
    File "/nix/store/jn8dic1klsd1d550wb682ssnq9wsffg5-python3-3.7.5/lib/python3.7/ctypes/__init__.py", line 364, in __init__
      self._handle = _dlopen(self._name, mode)
  OSError: dlopen(/nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib, 6): Library not loaded: libsndio.7.0.dylib
    Referenced from: /nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib
    Reason: image not found
builder for '/nix/store/3w4q15d3xqfg8rffna1m8wiqdw8lsbk8-python3.8-mpv-0.3.9.drv' failed with exit code 1; last 10 log lines:
  running install tests
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/private/tmp/nix-build-python3.8-mpv-0.3.9.drv-0/source/mpv.py", line 46, in <module>
      backend = CDLL(sofile)
    File "/nix/store/n72fdnrhg2p348z2z2c94ncxx0vm4wdm-python3-3.8.0/lib/python3.8/ctypes/__init__.py", line 369, in __init__
      self._handle = _dlopen(self._name, mode)
  OSError: dlopen(/nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib, 6): Library not loaded: libsndio.7.0.dylib
    Referenced from: /nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib
    Reason: image not found
cannot build derivation '/nix/store/5rs2ac1ak84kpna4fhwivbb27ks4y86m-env.drv': 2 dependencies couldn't be built
[6 built (2 failed), 57 copied (209.0 MiB), 48.5 MiB DL]
error: build of '/nix/store/5rs2ac1ak84kpna4fhwivbb27ks4y86m-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72033
2 package failed to build:
python37Packages.mpv python38Packages.mpv

4 package were build:
curseradio mpc-qt mpv sndio

(though of course those failed builds weren't even attempting to build before, so this is at least an improvement)

@marsam marsam merged commit 846da8b into NixOS:master Oct 28, 2019
@marsam
Copy link
Contributor Author

marsam commented Oct 28, 2019 •
edited

I'm not using nix on Darwin, am I even able to test and approve this?

sorry about the noise, I think it should not cause any relevant change to the NixOS package

@marsam marsam deleted the fix-sndio-darwin branch October 28, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Chiiruno @risicle