Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncurses: add infocmp utility #72135

Merged
merged 1 commit into from Nov 12, 2019
Merged

ncurses: add infocmp utility #72135

merged 1 commit into from Nov 12, 2019

Conversation

listx
Copy link
Member

@listx listx commented Oct 28, 2019

Motivation for this change

Add the "infocmp" binary to the PATH (AFAICS, the manpages for the ncurses package describe this utility, but it is never installed by the package).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@dtzWill
Copy link
Member

dtzWill commented Oct 28, 2019

FWIW it is installed, but in the dev output. I'm not sure offhand why each binary is in each output toe is also in dev...

As an aside, if we do poke this derivation please consider updating to latest snapshot O:).

(if unsure please ping me about it 😇)

@Mic92
Copy link
Member

Mic92 commented Oct 28, 2019

Also this should be rebased to the staging branch.

@listx
Copy link
Member Author

listx commented Oct 28, 2019

FWIW it is installed, but in the dev output.

What is the dev output? I tried looking in the /nix store path but could not find it anywhere.

I'm not sure offhand why each binary is in each output toe is also in dev...

As an aside, if we do poke this derivation please consider updating to latest snapshot O:).

Do you mean updating it to the latest upstream version? I'm wary of doing that because I don't want to risk breaking other things (...I just want infocmp to be in my PATH when I install ncurses).

(if unsure please ping me about it )

@Mic92

Also this should be rebased to the staging branch.

Which branch is the staging branch? 😅

@Mic92
Copy link
Member

Mic92 commented Oct 29, 2019

@listx it's literally called staging.

@FRidh FRidh changed the base branch from master to staging October 29, 2019 14:21
@FRidh FRidh added this to WIP in Staging Oct 29, 2019
@listx
Copy link
Member Author

listx commented Oct 29, 2019

@listx it's literally called staging.

Indeed. How embarrassing (I just noticed that I had opened this PR against "staging" branch... oops). Fixed.

@FRidh FRidh moved this from WIP to Needs review in Staging Nov 3, 2019
@FRidh FRidh merged commit c7fbf93 into NixOS:staging Nov 12, 2019
Staging automation moved this from Needs review to Done Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@listx @dtzWill @Mic92 @FRidh