Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmymoney: fix build #72221

Merged
merged 2 commits into from Oct 29, 2019
Merged

kmymoney: fix build #72221

merged 2 commits into from Oct 29, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 29, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh changed the title kmymoney: fix python2 build kmymoney: fix build Oct 29, 2019
@jonringer
Copy link
Contributor

do you mind changing the commits to match:

python3Packages.weboob: 1.3 -> 1.5
kmymoney: 5.0.5 -> 5.0.7

@Mic92
python3.pkgs.weboob: 1.3 -> 1.5
b34dc11 
html2text is python3 only now, which implicitly also affects weboob.
@Mic92
kmymoney: 5.0.5 -> 5.0.7
33f28bc
@Mic92
Copy link
Member Author

Mic92 commented Oct 29, 2019

Done

@jonringer
Copy link
Contributor

@GrahamcOfBorg build kmymoney

jonringer
jonringer approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (1 broken on master)
diff LGTM
kmymoney launches fine

[4 built (1 failed), 149 copied (488.2 MiB), 86.3 MiB DL]
error: build of '/nix/store/wrywxdg732501qays5rbdq1lykybpahs-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72221
1 package failed to build:
python27Packages.weboob

3 package were build:
kmymoney python37Packages.weboob python38Packages.weboob

@jonringer jonringer merged commit 91f4d7a into NixOS:master Oct 29, 2019
@Mic92 Mic92 deleted the kmymoney branch October 29, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @jonringer