Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clightning: 0.7.2.1 -> 0.7.3 #72219

Merged
merged 1 commit into from Oct 29, 2019
Merged

clightning: 0.7.2.1 -> 0.7.3 #72219

merged 1 commit into from Oct 29, 2019

Conversation

jonasnick
Copy link
Contributor

@jonasnick jonasnick commented Oct 29, 2019 •
edited

Motivation for this change

New release. Requires gettext to build as mentioned in the changelog (https://github.com/ElementsProject/lightning/blob/v0.7.3/CHANGELOG.md).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (ArchLinux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jb55

@ofborg ofborg bot requested a review from jb55 October 29, 2019 08:05
jonringer
jonringer reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  gcc -DBINTOPKGLIBEXECDIR="\"../libexec/c-lightning\"" -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -Werror -Wno-maybe-uninitialized -std=gnu11 -g -fstack-protector -Og -I ccan -I external/libwally-core/include/ -I external/libwally-core/src/secp256k1/include/ -I external/jsmn/ -I external/libbacktrace/ -I external/libbacktrace-build -I external/libsodium/src/libsodium/include -I . -I/usr/local/include    -DSHACHAIN_BITS=48 -DJSMN_PARENT_LINKS  -DCOMPAT_V052=1 -DCOMPAT_V060=1 -DCOMPAT_V061=1 -DCOMPAT_V062=1 -DCOMPAT_V070=1 -DBUILD_ELEMENTS=1 -DBINTOPKGLIBEXECDIR="\"../libexec/c-lightning\""  -c -o bitcoin/varint.o bitcoin/varint.c
  devtools/sql-rewrite.py wallet/statements.po postgres > wallet/gen_db_postgres.c
  /nix/store/zavn4np1jvm79f0rafkv0p1mrag09qkz-bash-4.4-p23/bin/bash: devtools/sql-rewrite.py: /usr/bin/env: bad interpreter: No such file or directory
  make: *** [wallet/Makefile:49: wallet/gen_db_postgres.c] Error 126
  rm external/libwally-core/src/secp256k1/libsecp256k1.la
cannot build derivation '/nix/store/jjdbnhq1saq6lb6rlv35idskjnn3wsab-env.drv': 1 dependencies couldn't be built

@jonasnick
Copy link
Contributor Author

@jonringer sorry I didn't test on a NixOS machine before. It's fixed now after adding devtools/sql-rewrite.py to the patchShebang list.

@jonringer
Copy link
Contributor

all good

@jonasnick
Copy link
Contributor Author

oops forgot to push

@jonringer
Copy link
Contributor

@GrahamcOfBorg build clightning

jb55
jb55 approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's working over here!

jonringer
jonringer approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72219
1 package were build:
clightning

@jonringer jonringer merged commit 9aea511 into NixOS:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonasnick @jonringer @jb55