Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profanity: 0.7.0 -> 0.7.1 #72121

Merged
merged 1 commit into from Oct 28, 2019
Merged

profanity: 0.7.0 -> 0.7.1 #72121

merged 1 commit into from Oct 28, 2019

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Oct 27, 2019

Changelog: https://github.com/profanity-im/profanity/releases

Signed-off-by: devhell devhell@mailfresser.de

Motivation for this change

Standard update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@devhell
profanity: 0.7.0 -> 0.7.1
3b32a1c 
Changelog: https://github.com/profanity-im/profanity/releases

Signed-off-by: devhell <devhell@mailfresser.de>
@devhell
Copy link
Contributor Author

devhell commented Oct 27, 2019

@GrahamcOfBorg build

jonringer
jonringer approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
output LGTM
leaf package

[3 built, 2 copied (0.4 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72121
1 package were build:
profanity

@jonringer
Copy link
Contributor

@GrahamcOfBorg build profanity

@jonringer jonringer merged commit 4fbb0a3 into NixOS:master Oct 28, 2019
@devhell devhell deleted the profanity-0.7.1 branch October 28, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devhell @jonringer