Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdf5: don't force GCC 7 #72124

Merged
merged 1 commit into from Oct 28, 2019
Merged

hdf5: don't force GCC 7 #72124

merged 1 commit into from Oct 28, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

HDF5 seems to build fine with GCC 8 now and I don't like building extra GCCs on my ARM machines. See #40704 for when the GCC 7 override was added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Synthetica9

@lopsided98
Copy link
Contributor Author

@GrahamcOfBorg build hdf5

veprbl
veprbl approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on darwin too.

@veprbl veprbl merged commit d448421 into NixOS:master Oct 28, 2019
@lopsided98 lopsided98 deleted the hdf5-gcc7 branch November 5, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @veprbl