Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtranslator: 3.32.1 → 3.34.0 #72134

Merged
merged 1 commit into from Oct 28, 2019
Merged

gtranslator: 3.32.1 → 3.34.0 #72134

merged 1 commit into from Oct 28, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 28, 2019 •
edited

There is like ton of warnings:

(gtranslator:635): GtkSourceView-CRITICAL **: 03:25:48.702: gtk_source_buffer_new_with_language: assertion 'GTK_SOURCE_IS_LANGUAGE (language)' failed

(gtranslator:635): GtkSourceView-CRITICAL **: 03:25:48.702: gtk_source_buffer_set_highlight_syntax: assertion 'GTK_SOURCE_IS_BUFFER (buffer)' failed

(gtranslator:635): GtkSourceView-WARNING **: 03:25:48.702: Failed to load '/nix/store/b3ksa6kz93q8ymbl0ipba5aji4wvvjaz-gtranslator-3.34.0/share/gtranslator/sourceview/gtranslator.lang': could not find the RelaxNG schema file

most likely caused by this weird thing:

https://gitlab.gnome.org/GNOME/gtranslator/commit/11b7fb5a7ac361133f7c895b74a083f4925131a6#526d558dcb822f9947243577ed64fa2c60980044_346_349

but it appears to work otherwise.

jonringer
jonringer approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
output LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72134
1 package were build:
gtranslator

@jonringer jonringer merged commit eab20ca into NixOS:master Oct 28, 2019
@jtojnar jtojnar deleted the gtranslator-3.34 branch October 28, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @jonringer