Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networkd: add ipv4-fallback and fallback as valid options to LinkLocalAddressing #72191

Merged
merged 1 commit into from Oct 28, 2019
Merged

nixos/networkd: add ipv4-fallback and fallback as valid options to LinkLocalAddressing #72191

merged 1 commit into from Oct 28, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 28, 2019

Motivation for this change

Both options were introduced in systemd v243[1]. Those options can be
used to ensure that LinkLocalAddressing is only configured for a given
interface if DHCPv4 fails. To quote systemd.network(5):

If "fallback" or "ipv4-fallback" is specified, then an IPv4
link-local address is configured only when DHCPv4 fails. If "fallback", an IPv6 link-local
address is always configured, and if "ipv4-fallback", the address is not configured. Note
that, the fallback mechanism works only when DHCPv4 client is enabled, that is, it requires
"DHCP=yes" or "DHCP=ipv4".

[1] systemd/systemd@8bc17bb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
nixos/networkd: add ipv4-fallback and fallback as valid options t…
47724fc 
…o `LinkLocalAddressing`

Both options were introduced in systemd v243[1]. Those options can be
used to ensure that LinkLocalAddressing is only configured for a given
interface if DHCPv4 fails. To quote `systemd.network(5)`:

```
If "fallback" or "ipv4-fallback" is specified, then an IPv4
link-local address is configured only when DHCPv4 fails. If "fallback", an IPv6 link-local
address is always configured, and if "ipv4-fallback", the address is not configured. Note
that, the fallback mechanism works only when DHCPv4 client is enabled, that is, it requires
"DHCP=yes" or "DHCP=ipv4".
```

[1] systemd/systemd@8bc17bb
@Ma27 Ma27 requested a review from fpletz October 28, 2019 19:58
@Ma27
Copy link
Member Author

Ma27 commented Oct 28, 2019

As we use systemd-v243 on release-19.09 as well I think that it's fairly reasonable to backport this as well.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 28, 2019
@fpletz fpletz merged commit b82026d into NixOS:master Oct 28, 2019
@Ma27 Ma27 deleted the add-linklocal-option branch October 28, 2019 21:10
@Ma27
Copy link
Member Author

Ma27 commented Oct 28, 2019

Backported as 742f0ff

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @fpletz