HTML: COOP+COEP blob URL popup #19947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
|
wpt-firefox-nightly-stability is failing on Taskcluster |
|
I'm having a bit of difficulty assessing the correctness of the test without a spec or an implementation. :) I didn't find anything clearly wrong though, if that helps. |
Part of #18354.
annevk
force-pushed
the
annevk/coop-coep-blob-url-popup
branch
from
4d43181
to
941e4ec
Compare
wpt-pr-bot
requested review from
arturjanc,
hemeryar,
jugglinmike,
mikewest,
ParisMeuleman and
valenting
|
FWIW, this tries to open a same-origin blob: URL from a COOP+COEP environment and expects that to not replace the BCG. If we don't want to break blob: URLs this is the simplest case that would have to work for popups, though workers are probably a more relevant test come to think of it. |
zcorpan
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18354.