Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of SVN ID line as it is not needed. #7808

Merged
merged 1 commit into from Nov 10, 2019
Merged

Removal of SVN ID line as it is not needed. #7808

merged 1 commit into from Nov 10, 2019

Conversation

sdcloudt
Copy link
Contributor

SVN is not used anymore. Therefore the /* $Id$ */ lines are not necessary. This PR removes most, if not all, id lines.

I checked the commit, but I would appreciate as checking 1203 files is a job which I nobody wants to do.

I used the following line of bash code to remove all /* $Id$ */ lines:

for file in **/*
do
  sed -Ei '1{N; /^\/\*\s\$Id\$\s\*\/\n$/d}' $file
done

@sdcloudt sdcloudt mentioned this pull request Oct 28, 2019
Closed
@glx22
Copy link
Contributor

glx22 commented Oct 28, 2019 •
edited

*.sq files are generated, you'll need to change

OpenTTD/src/script/api/squirrel_export.awk

Lines 57 to 58 in f1204f0

print "/* $I" "d$ */" CR
print "" CR
and

OpenTTD/src/script/api/squirrel_export.vbs

Lines 86 to 87 in f1204f0

file.WriteLine "/* $I" & "d$ */"
file.WriteLine ""

@LordAro
Copy link
Member

LordAro commented Oct 28, 2019

Also remove that merge commit, not sure how it got past the checker...

@glx22
Copy link
Contributor

glx22 commented Oct 28, 2019

The checker accepts it because we rebase before the check so it just disappear I think

@sdcloudt
Copy link
Contributor Author

I screwed up the git, I am fixing it.

@sdcloudt
Copy link
Contributor Author

I removed some more $Id$ tags, and, removed the generated $Id$ output.

LordAro
LordAro reviewed Oct 29, 2019
View reviewed changes
media/extra_grf/shore.nfo Outdated Show resolved Hide resolved
@LordAro LordAro merged commit 13cc8a0 into OpenTTD:master Nov 10, 2019
@PeterN PeterN mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdcloudt @glx22 @LordAro