Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] melpa-packages: 2019-10-24 #72177

Merged
merged 1 commit into from Nov 1, 2019
Merged

[19.09] melpa-packages: 2019-10-24 #72177

merged 1 commit into from Nov 1, 2019

Conversation

rasendubi
Copy link
Member

Motivation for this change

lua-mode issue: #71948
original PR: #71922

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

cc @endgame who requested backport

@rasendubi
melpa-packages: 2019-10-24
eb0e901 
(cherry picked from commit 8bb70c8)

emacsPackages.lua-mode fails to build. Update fixes that.
@rasendubi rasendubi added 6.topic: emacs 8.has: port to stable A PR already has a backport to the stable release. labels Oct 28, 2019
@rasendubi rasendubi changed the title melpa-packages: 2019-10-24 [19.09] melpa-packages: 2019-10-24 Oct 28, 2019
@adisbladis adisbladis changed the base branch from nixos-19.09 to release-19.09 October 29, 2019 10:05
@adisbladis adisbladis merged commit a43046e into NixOS:release-19.09 Nov 1, 2019
endgame
endgame reviewed Nov 6, 2019
View reviewed changes
pkgs/applications/editors/emacs-modes/recipes-archive-melpa.json
],
"commit": "95c64bb5634035630e8c59d10d4a1d1003265743",
"sha256": "0cawb544qylifkvqads307n0nfqg7lvyphqbpbzr2xvr5iyi4901"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixos-rebuild switch --upgrade still fails trying to find something with this sha. Should it really take five days for the merge to trigger a channel update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The channels advance when Hydra builds a substantial subset of packages. (Because people hate building stuff on their computers. Especially heavy beasts like browsers, libreoffice, etc.) That's why it takes so long.

This fix has already made to nixos-19.09-small channel—this is the channel that waits for fewer packages to build, so it usually moves faster.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer, I might move to -small for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endgame endgame endgame left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

Assignees
No one assigned
Labels
6.topic: emacs 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rasendubi @endgame @adisbladis