Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.chardet: fix tests #72229

Closed
wants to merge 1 commit into from
Closed

pythonPackages.chardet: fix tests #72229

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 29, 2019 •
edited

Motivation for this change

noticed it was broken

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner October 29, 2019 09:10
@ofborg ofborg bot requested a review from domenkozar October 29, 2019 10:07
@FRidh
Copy link
Member

FRidh commented Oct 29, 2019

With which Python was this broken? Considering the amount of rebuilds it was working somewhere, otherwise it would not have landed in master.

@FRidh FRidh added this to Needs review in Staging Oct 29, 2019
@jonringer
Copy link
Contributor Author

Hmmm, it looks to have fixed itself.. or i just need more sleep...

@jonringer jonringer closed this Oct 29, 2019
@jonringer jonringer deleted the fix-chardet branch October 29, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh