Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpxsee: 7.15 -> 7.16 #72230

Merged
merged 1 commit into from Oct 30, 2019
Merged

gpxsee: 7.15 -> 7.16 #72230

merged 1 commit into from Oct 30, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Oct 29, 2019

Motivation for this change

Changelog:

  • Added support for Garmin GPI files.
  • Hyperlink + copy&paste enabled tool tips.
  • Various minor bug fixes in data loading.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/9ycbnk607va99iyq47h7c55f0hsf39zd-gpxsee-7.15
/nix/store/9ycbnk607va99iyq47h7c55f0hsf39zd-gpxsee-7.15	 263.7M
$ nix path-info -Sh /nix/store/bpcsax7j0dsx82bbkqw65gfi3fjzwflp-gpxsee-7.16
/nix/store/bpcsax7j0dsx82bbkqw65gfi3fjzwflp-gpxsee-7.16	 263.7M
Notify maintainers

cc @womfoo

@ofborg ofborg bot requested a review from womfoo October 29, 2019 10:22
@jonringer
Copy link
Contributor

@GrahamcOfBorg build gpxsee

jonringer
jonringer approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
gui launches fine
leaf package

[3 built, 131 copied (609.0 MiB), 141.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72230
1 package were build:
gpxsee

@jonringer jonringer merged commit 236bbbe into NixOS:master Oct 30, 2019
@sikmir sikmir deleted the gpxsee branch October 30, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@womfoo womfoo Awaiting requested review from womfoo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @jonringer