Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python35: 3.5.7 -> 3.5.8 #72223

Merged
merged 1 commit into from Oct 29, 2019
Merged

python35: 3.5.7 -> 3.5.8 #72223

merged 1 commit into from Oct 29, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 29, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh added 6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 29, 2019
@FRidh FRidh self-assigned this Oct 29, 2019
jonringer
jonringer approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to build python35Packages.pytest python35Packages.requests

[02:08:23] jon@jon-desktop /home/jon/projects/nixpkgs ((456f0997575...))
$ nix build -f . --keep-going python35Packages.pytest python35Packages.requests
[60 built, 16 copied (14.6 MiB), 7.6 MiB DL]

@FRidh FRidh merged commit ccf514a into NixOS:master Oct 29, 2019
@FRidh FRidh deleted the python35 branch October 29, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees

@FRidh FRidh

Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @jonringer