Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.snuggs: 1.4.3 -> 1.4.7 #72226

Merged
merged 1 commit into from Oct 29, 2019
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 29, 2019

Motivation for this change

noticed it was broken while reviewing another package

builder for '/nix/store/6pbqqq6bl1s91kf4yhdnn5q02zaafl4k-python3.7-snuggs-1.4.3.drv' failed with exit code 1; last 10 log lines:
          assert excinfo.value.offset == 3
          exception_options = ['expected a function or operator',
                               'Expected {Forward: ... | Forward: ...}']
  >       assert str(excinfo.value) in exception_options
  E       assert 'Expected {Forward: Group:({{{{Suppress:("(") map | partial} {{{"nil" | : ...} | * | + | / | - | & | | | <= | < | == |... starting with \' ending with \' | quoted string, starting with " ending with "}}]...} Suppress:(")")})}, found \'b\' ' in ['expected a function or operator', 'Expected {Forward: ... | Forward: ...}']
  E        +  where 'Expected {Forward: Group:({{{{Suppress:("(") map | partial} {{{"nil" | : ...} | * | + | / | - | & | | | <= | < | == |... starting with \' ending with \' | quoted string, starting with " ending with "}}]...} Suppress:(")")})}, found \'b\' ' = str(ExpressionError('Expected {Forward: Group:({{{{Suppress:("(") map | partial} {{{"nil" | : ...} | * | + | / | - | & | |...starting with \' ending with \' | quoted string, starting with " ending with "}}]...} Suppress:(")")})}, found \'b\' '))
  E        +    where ExpressionError('Expected {Forward: Group:({{{{Suppress:("(") map | partial} {{{"nil" | : ...} | * | + | / | - | & | |...starting with \' ending with \' | quoted string, starting with " ending with "}}]...} Suppress:(")")})}, found \'b\' ') = <ExceptionInfo ExpressionError tblen=3>.value

  test_snuggs.py:220: AssertionError
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[6 built, 1 copied (33.3 MiB), 7.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72226
6 package were build:
python27Packages.rasterio python27Packages.snuggs python37Packages.rasterio python37Packages.snuggs python38Packages.rasterio python38Packages.snuggs

@jonringer jonringer requested a review from FRidh as a code owner October 29, 2019 08:58
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.rasterio python27Packages.snuggs python37Packages.rasterio python37Packages.snuggs python38Packages.rasterio python38Packages.snuggs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants