Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.4.1 -> 1.5.0 #72263

Merged
merged 1 commit into from Oct 30, 2019
Merged

matrix-synapse: 1.4.1 -> 1.5.0 #72263

merged 1 commit into from Oct 30, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 29, 2019

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.5.0

Please note that there's a security-relevant fix in this release: matrix-org/synapse#6262

I'm not sure if we want to backport this minor release as well, but we should add the patch to release-19.09 at least.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 29, 2019
@ofborg ofborg bot requested review from pacien, Ekleog and Ralith October 29, 2019 18:10
@Ekleog
Copy link
Member

Ekleog commented Oct 30, 2019

Either backporting or adding the patch would make sense to me, if the patch applies cleanly.

@ofborg build nixosTests.matrix-synapse

@Ekleog Ekleog merged commit 39a8f71 into NixOS:master Oct 30, 2019
@Ma27 Ma27 deleted the bump-matrix-synapse branch October 31, 2019 07:25
@Ma27
Copy link
Member Author

Ma27 commented Oct 31, 2019

We discussed about this in the [Nix] Matrix Subsystem-channel and most people were in favor of backporting the release. So unless there are any objections, I'd backport later that day :)

@Ma27
Copy link
Member Author

Ma27 commented Oct 31, 2019

Just backported as 0fbf523, c5aabb0.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@pacien pacien Awaiting requested review from pacien

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @Ekleog @Ralith