Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.8.28 -> 1.8.29 #72262

Merged
merged 1 commit into from Nov 5, 2019
Merged

sudo: 1.8.28 -> 1.8.29 #72262

merged 1 commit into from Nov 5, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 29, 2019

Motivation for this change

https://www.sudo.ws/stable.html#1.8.29

Build tweak: fix build failure when attempting to check that
the "existing" sudoers file on $out/etc/sudoers parses clean--
this update changed precondition for this test to check if
DESTDIR is non-empty instead of previous behavior
"does the file exist".

Still going through changes carefully, another set of eyes/testing
appreciated :). Borked sudo is a sad Nix'er :3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eelco

Did the issue with ssh+sudo -> hang ever get resolved?
If not, the changes/bugfixes in this update might explain what was
happening...

@ofborg ofborg bot requested a review from edolstra October 29, 2019 17:58
ajs124
ajs124 requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the version bump?

@dtzWill
sudo: 1.8.28 -> 1.8.29
640677c 
https://www.sudo.ws/stable.html#1.8.29

Build tweak: fix build failure when attempting to check that
the "existing" sudoers file on $out/etc/sudoers parses clean--
this update changed precondition for this test to check if
DESTDIR is non-empty instead of previous behavior
"does the file exist".
@dtzWill
Copy link
Member Author

dtzWill commented Oct 29, 2019

Where's the version bump?

EEP! Haha sorry about that-- update got lost in the patch shuffle, somehow. Yubikey acting up making normal workflows difficult whimsically, but even so .. missing the update?! And transferring the commit message to the fixup?? Gold star ;).

Anyway, update now included sorry about that!

@dtzWill
Copy link
Member Author

dtzWill commented Oct 29, 2019

cc #70418 in case this helps make sense of that lame situation? 🐱

@dtzWill dtzWill merged commit 4db1cae into NixOS:staging Nov 5, 2019
@dtzWill dtzWill deleted the update/sudo-1.8.29 branch November 5, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 requested changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @ajs124