Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse: 0.5.0 -> 0.5.2 #72180

Merged
merged 1 commit into from Oct 28, 2019
Merged

reuse: 0.5.0 -> 0.5.2 #72180

merged 1 commit into from Oct 28, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Oct 28, 2019

Motivation for this change

A new version was released.

Also fixing metadata.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

@jonringer
Copy link
Contributor

do you mind squash the commits? reuse: 0.5.0 -> 0.5.2 is fine.

If the pypi tar ball doesn't have tests, then I would prefer to pull from github

@davidak
Copy link
Member Author

davidak commented Oct 28, 2019

do you mind squash the commits?

i thought it makes sense to have the changes separate, so they could be reverted individually, like the src

is there a policy to squash all commits in a PR?

(you can also squash them with github when merging)

If the pypi tar ball doesn't have tests, then I would prefer to pull from github

that makes sense. it actually has no tests there

@jonringer
Copy link
Contributor

They also have a 0.5.2 release https://github.com/fsfe/reuse-tool/releases, probably don't need to pull from pypi

@jonringer
Copy link
Contributor

is there a policy to squash all commits in a PR?

https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches , specifically:

If you have commits pkg-name: oh, forgot to insert whitespace: squash commits in this case. Use git rebase -i.

i would consider fixing a license to fall under that category

@jonringer
Copy link
Contributor

Personally, i like to rebase and merge. This avoids there being a "merge" commit

@davidak
Copy link
Member Author

davidak commented Oct 28, 2019

yes, that's good. i will squash

@davidak davidak changed the title reuse update, fetch from pypi, fix license reuse: 0.5.0 -> 0.5.2 Oct 28, 2019
jonringer
jonringer approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

[3 built, 22 copied (9.7 MiB), 1.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72180
1 package were build:
reuse

@jonringer
Copy link
Contributor

@GrahamcOfBorg build reuse

@jonringer jonringer merged commit 479f75d into NixOS:master Oct 28, 2019
@jonringer
Copy link
Contributor

Thanks for submitting the PR

@davidak davidak deleted the reuse_update branch October 28, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidak @jonringer