Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb-connector-c: fix crypt_libs #72181

Merged
merged 1 commit into from Oct 29, 2019
Merged

mariadb-connector-c: fix crypt_libs #72181

merged 1 commit into from Oct 29, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 28, 2019 •
edited

Motivation for this change

Fixed this error in Darwin

[ 37%] Linking C shared module sha256_password.so
Undefined symbols for architecture x86_64:
  "_BIO_free", referenced from:
      _auth_sha256_client in sha256_pw.c.o
  "_BIO_new_mem_buf", referenced from:
      _auth_sha256_client in sha256_pw.c.o
  "_ERR_clear_error", referenced from:
      _auth_sha256_client in sha256_pw.c.o
  "_PEM_read_bio_RSA_PUBKEY", referenced from:
      _auth_sha256_client in sha256_pw.c.o
  "_RSA_free", referenced from:
      _auth_sha256_client in sha256_pw.c.o
  "_RSA_public_encrypt", referenced from:
      _auth_sha256_client in sha256_pw.c.o
  "_RSA_size", referenced from:
      _auth_sha256_client in sha256_pw.c.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/sha256_password.dir/build.make:84: sha256_password.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:237: CMakeFiles/sha256_password.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/npxzwxwzvyx7rk9jpamdpaggp556m8vd-mariadb-connector-c-3.1.4.drv' failed with exit code 2
error: build of '/nix/store/npxzwxwzvyx7rk9jpamdpaggp556m8vd-mariadb-connector-c-3.1.4.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 28, 2019

@GrahamcOfBorg build mariadb-connector-c

@ofborg ofborg bot requested a review from globin October 28, 2019 17:26
@jonringer
Copy link
Contributor

do you mind if i cherry pick this on my other PR? I was holding off merging it because of this issue

#71860

@jonringer
Copy link
Contributor

actually, better yet, I'll just get this in, then rebase on top of it <3

jonringer
jonringer approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff/patch LGTM
builds on linux and darwin

@jonringer jonringer merged commit 3281d30 into NixOS:staging Oct 29, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 29, 2019

Thanks!

@Izorkin Izorkin deleted the connector-c-fix branch October 29, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @jonringer