Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crawl: 0.23.2 -> 0.24.0 #72155

Merged
merged 1 commit into from Nov 10, 2019
Merged

crawl: 0.23.2 -> 0.24.0 #72155

merged 1 commit into from Nov 10, 2019

Conversation

lightbulbjim
Copy link
Contributor

@lightbulbjim lightbulbjim commented Oct 28, 2019 •
edited

Motivation for this change

Updating to latest version.

Icon patch has been removed as it is included in the new version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar

@ofborg ofborg bot requested a review from abbradar October 28, 2019 10:35
@azuzunaga
Copy link
Contributor

Builds on macOS. I did the following:

  • nix-build -A crawl
  • nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of binary file 
    $ ./result/bin/crawl --version
Crawl version 0.24.0
Save file version 34.211
Compiled with GCC 4.2.1 Compatible Clang 7.1.0 (tags/RELEASE_710/final)
Build platform: x86_64-apple-darwin19.0.0
Platform: x86_64-apple-darwin19.0.0
CFLAGS: -O2 -pipe -Wall -Wformat-security -Wundef -Wno-array-bounds -Wno-format-zero-length -Wmissing-declarations -Wredundant-decls -Wno-tautological-unsigned-enum-zero-compare -Wno-parentheses -Wwrite-strings -Wshadow -pedantic -Wuninitialized -Iutil -I. -isystem /nix/store/0jywmrg1liyj2a3dd0wr8m529dqnxbxd-lua-5.1.5/include -Irltiles -DWIZARD -DASSERTS -DCLUA_BINDINGS -DSAVE_DIR_PATH="~/.crawl" -DDATA_DIR_PATH="/nix/store/qy8p1llzr77sgsdw36l9ypia7p9xsfya-crawl-0.24.0/" -D_DARWIN_C_SOURCE -isystem /nix/store/kn9vmxkfpa69w3j9rkm12zr728ix2s2g-ncurses-6.1-20190112-dev/include
LDFLAGS: -rdynamic -O2

@lightbulbjim
Copy link
Contributor Author

Thanks for testing!

c0bw3b
c0bw3b approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs (tutorial) on nixos

Result of nix-review pr 72155 1

2 package were build:
  • crawl
  • crawlTiles

@c0bw3b c0bw3b merged commit 04d6338 into NixOS:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lightbulbjim @azuzunaga @c0bw3b