nixos/vimPlugins: add plugins + update #72241
Conversation
ofborg
bot
added
6.topic: vim
8.has: package (new)
pkgs/misc/vim-plugins/overrides.nix
Outdated
| @@ -91,6 +91,18 @@ self: super: { | |||
| }; | |||
| }; | |||
|
|
|||
| # do not auto-update this one, as the name clashes with calendar-vim | |||
There was a problem hiding this comment.
In that case we should have some way for the user to distinguish the two. Maybe it was a mistake to have the plugins in nixpkgs without namespaces.
Ideally you'd implement alias support in our plugin update infrastructure (calendar-vim as mattn-calendar-vim in plugin-list), but if you don't want to do that we should at least choose a more descriptive name.
There was a problem hiding this comment.
I'm fine with adding that as an alias in plugin-list; should the package definition stay where it is in overrides.nix? If it's added to vim-plugin-list I'm assuming it'll have a naming conflict with calendar-vim.
There was a problem hiding this comment.
No I meant that if you want to go down that road, you'd have to adapt update.py to work with statements like calendar-vim as mattn-calendar-vim in plugin-list. That way no override would be necessary and auto updates would work.
There was a problem hiding this comment.
Ah, gotcha. I can look into that, seems like it would be a useful feature to have. Would it be best to put this PR on hold and merge that in separately?
There was a problem hiding this comment.
Whatever way you prefer. As long as the change to update.py is in a separate commit that is fine by me. If you want to do a manual override as a stopgap first that is also okay.
There was a problem hiding this comment.
Great, sounds good to me.
There was a problem hiding this comment.
Okay, ping me if you do decide to open a different PR for it.
There was a problem hiding this comment.
@timokau Just pushed changes to update.py to add alias support; see the first commit in the PR. Also reupdated plugins in the update commit, and moved vim-docbk-snippets from overrides.nix into vim-plugin-names since it works with the alias support :)
Plugins in `plugin-list` can now optionally specify an alias name, to avoid naming collisions if plugins have the same repo name. For example, specifying `author/common-plugin as author-common-plugin` will use `author-common-plugin` as the package name in `generated.nix`.
init at 2014-11-04
ofborg
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
|
we should also update |
|
but that can be done in another PR, I'll get this in as it's been a while |
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM
commits LGTM
[98 built, 33 copied (881.5 MiB), 204.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72241
49 package were build:
vimPlugins.VimOrganizer vimPlugins.alchemist-vim vimPlugins.awesome-vim-colorschemes vimPlugins.calendar-vim vimPlugins.coc-eslint vimPlugins.coc-imselect vimPlugins.coc-java vimPlugins.coc-tsserver vimPlugins.editorconfig-vim vimPlugins.falcon vimPlugins.fzf-vim vimPlugins.ghcid vimPlugins.gv-vim vimPlugins.kotlin-vim vimPlugins.lightline-vim vimPlugins.mattn-calendar-vim vimPlugins.ncm2-ultisnips vimPlugins.neosnippet-vim vimPlugins.ultisnips vimPlugins.unicode-vim vimPlugins.utl-vim vimPlugins.vim-airline vimPlugins.vim-airline-themes vimPlugins.vim-android vimPlugins.vim-clojure-highlight vimPlugins.vim-clojure-static vimPlugins.vim-devicons vimPlugins.vim-dirvish vimPlugins.vim-docbk-snippets vimPlugins.vim-elixir vimPlugins.vim-glsl vimPlugins.vim-go vimPlugins.vim-jsx-pretty vimPlugins.vim-ledger vimPlugins.vim-plug vimPlugins.vim-polyglot vimPlugins.vim-projectionist vimPlugins.vim-salve vimPlugins.vim-sexp vimPlugins.vim-sexp-mappings-for-regular-people vimPlugins.vim-signify vimPlugins.vim-slime vimPlugins.vim-sneak vimPlugins.vim-snippets vimPlugins.vim-terraform vimPlugins.vim-test vimPlugins.vimtex vimPlugins.yats-vim vimPlugins.youcompleteme
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
Missing plugins in vimPlugins.
Things done
Update vimPlugins; add the following vimPlugins:
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @