Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadow: replace gnome-doc-utils with itstool #72246

Merged
merged 1 commit into from
Nov 3, 2019
Merged

shadow: replace gnome-doc-utils with itstool #72246

merged 1 commit into from
Nov 3, 2019
+8 −2

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 29, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@FRidh FRidh added the 2.status: work-in-progress This PR isn't done label Oct 29, 2019
@FRidh FRidh mentioned this pull request Oct 29, 2019
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Oct 29, 2019
@FRidh FRidh changed the title WIP shadow: replace gnome-doc-utils with itstool shadow: replace gnome-doc-utils with itstool Nov 3, 2019
@FRidh FRidh requested a review from jtojnar November 3, 2019 09:01
@FRidh FRidh removed the 2.status: work-in-progress This PR isn't done label Nov 3, 2019
@FRidh
Copy link
Member Author

FRidh commented Nov 3, 2019

@GrahamcOfBorg build shadow

@FRidh
shadow: replace gnome-doc-utils with itstool
555d824 
gnome-doc-utils is no longer supported and requires Python 2.
@FRidh FRidh merged commit b4270a7 into NixOS:staging Nov 3, 2019
@FRidh FRidh deleted the itstool branch November 3, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @jtojnar