[LayoutNG] Fix NGLineBreaker infinite loop when break-word
#18938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 9, 2019
This patch fixes NGLineBreaker not to go to an infinite loop when `break-word` and `nowrap` appear in specific combinations. Bug: 1001359 Change-Id: I0fb282e96eb29cd65033232329aaa5dc5be3da49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792040 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#694787}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1792040
branch
from
06f1209
to
d61e141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes NGLineBreaker not to go to an infinite loop
when
break-wordandnowrapappear in specificcombinations.
Bug: 1001359
Change-Id: I0fb282e96eb29cd65033232329aaa5dc5be3da49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792040
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694787}