Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT/common/security-features] Introduce downgrade origin types #18940

Merged
merged 1 commit into from Sep 12, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 9, 2019

As preparation for migrating wpt/upgrade-insecure-requests
to the /common/security-features generator framework
in https://chromium-review.googlesource.com/c/chromium/src/+/1788551,
this CL introduces downgrade origin type,
which is to be used to test upgrading on initial requests.

Bug: 1001422
Change-Id: Ia1f2dba1f7d894c0f2b5ba0b24835a9e86287d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787570
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695925}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

As preparation for migrating wpt/upgrade-insecure-requests
to the /common/security-features generator framework
in https://chromium-review.googlesource.com/c/chromium/src/+/1788551,
this CL introduces `downgrade` origin type,
which is to be used to test upgrading on initial requests.

Bug: 1001422
Change-Id: Ia1f2dba1f7d894c0f2b5ba0b24835a9e86287d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787570
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695925}
@foolip
Copy link
Member

foolip commented Sep 12, 2019

On Taskcluster, both wpt-chrome-dev-stability and wpt-firefox-nightly-stability say "Identified 2382 affected tests" and a few hours later "Task timeout after 7200 seconds. Force killing container." So this is #7660, as Taskcluster also has its limits.

@foolip
Copy link
Member

foolip commented Sep 12, 2019

The wpt.fyi checks show no change in results, so this change didn't break everything, and probably didn't introduce flakiness either. Admin merging.

@foolip foolip merged commit 2660fc4 into master Sep 12, 2019
@foolip foolip deleted the chromium-export-cl-1787570 branch September 12, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants