[WPT/common/security-features] Introduce downgrade redirection #18939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 9, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1787571
branch
from
db8e3be
to
06aced5
Compare
As preparation for migrating wpt/upgrade-insecure-requests to the /common/security-features generator framework in https://chromium-review.googlesource.com/c/chromium/src/+/1788551, this CL introduces `downgrade` redirection type, which is to be used to test upgrading on redirects. Bug: 1001422 Change-Id: I590015cdb48c9814135dbd61a91aa318ddeba2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787571 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#695934}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1787571
branch
from
06aced5
to
013fa21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As preparation for migrating wpt/upgrade-insecure-requests
to the /common/security-features generator framework
in https://chromium-review.googlesource.com/c/chromium/src/+/1788551,
this CL introduces
downgraderedirection type,which is to be used to test upgrading on redirects.
Bug: 1001422
Change-Id: I590015cdb48c9814135dbd61a91aa318ddeba2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787571
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695934}