Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddgr: 1.6 -> 1.7 #68357

Merged
merged 1 commit into from Oct 6, 2019
Merged

ddgr: 1.6 -> 1.7 #68357

merged 1 commit into from Oct 6, 2019

Conversation

markus1189
Copy link
Contributor

Motivation for this change

Update ddgr to 1.7 (https://github.com/jarun/ddgr/releases/tag/v1.7)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ceedubs

@ofborg ofborg bot requested a review from ceedubs September 9, 2019 14:52
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
ceedubs
ceedubs approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@c0bw3b c0bw3b merged commit a467383 into NixOS:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceedubs ceedubs ceedubs approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markus1189 @ceedubs @c0bw3b @lheckemann