Use promise in wpt tests to end the tests to avoid memory leak - Part 3 #18935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 9, 2019
When we add default tick duration of two-frame time, we see some tests memory leak which may end the tests when the page is still active, so I add promise to each tests, once the actions are all finished, we will call the test end in the promise callback. Bug: 606367 Change-Id: Ie63b8fd168426b84bedc6c31d5b3bdbb1813ccd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790742 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#699856}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1790742
branch
from
8d49ce8
to
08e87b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add default tick duration of two-frame time, we see some tests
memory leak which may end the tests when the page is still active, so
I add promise to each tests, once the actions are all finished, we will
call the test end in the promise callback.
Bug: 606367
Change-Id: Ie63b8fd168426b84bedc6c31d5b3bdbb1813ccd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790742
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699856}