Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.odoc: 1.3.0 → 1.4.2 #69278

Merged
merged 1 commit into from
Sep 24, 2019
Merged

ocamlPackages.odoc: 1.3.0 → 1.4.2 #69278

merged 1 commit into from
Sep 24, 2019
+8 −6

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 23, 2019

Motivation for this change

Ensures compatibility with OCaml 4.08

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@vbgl
ocamlPackages.odoc: 1.3.0 → 1.4.2
31aab48 
Ensures compatibility with OCaml 4.08
@vbgl vbgl added 8.has: package (update) This PR updates a package to a newer version 6.topic: ocaml labels Sep 23, 2019
@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 23, 2019
@vbgl
Copy link
Contributor Author

vbgl commented Sep 23, 2019

@GrahamcOfBorg build ocamlPackages.odoc

@Mic92 Mic92 merged commit 93a1acc into NixOS:master Sep 24, 2019
@vbgl vbgl deleted the ocaml-odoc-1.4.1 branch September 24, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: documentation This PR adds or changes documentation 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @Mic92