Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: Add gnutar and gzip to gitlab-sidekiq's path #68908

Merged
merged 1 commit into from Sep 23, 2019
Merged

nixos/gitlab: Add gnutar and gzip to gitlab-sidekiq's path #68908

merged 1 commit into from Sep 23, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Sep 16, 2019 •
edited

Motivation for this change

Tar and gzip are needed when importing GitLab project exports. Project imports are currently broken; this fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @flokli

@talyz
nixos/gitlab: Add gnutar and gzip to gitlab-sidekiq's path
aceac9d 
Tar and gzip are needed when importing GitLab project exports.
schneefux
schneefux approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@schneefux schneefux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiles & looks good to me 👍

@flokli flokli merged commit 6262e83 into NixOS:master Sep 23, 2019
@flokli
Copy link
Contributor

flokli commented Sep 23, 2019

Backported to 19.03 in 4d53b8e, to 19.09 in 7a7a80b.

@talyz talyz deleted the gitlab-import branch September 27, 2019 07:56
@bgamari bgamari mentioned this pull request Oct 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@schneefux schneefux schneefux approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @flokli @schneefux