Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: Temporary fix for kernel >= 5.3 #69323

Merged
merged 1 commit into from Sep 24, 2019
Merged

virtualbox: Temporary fix for kernel >= 5.3 #69323

merged 1 commit into from Sep 24, 2019

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 23, 2019

Motivation for this change

VirtualBox does not build with kernel 5.3 which is default with linuxPackages_latest.

Things done

Found a fix that hasn't yet been released for VirutalBox at https://www.virtualbox.org/ticket/18911 and added as a patch to the build.

Running nix-review but it's compiling several kernel versions at once so it may take a while.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/is-it-appropriate-to-open-a-nixpkgs-bug-to-track-an-upstream-bug/4109/4

@ofborg ofborg bot requested review from flokli and svanderburg September 23, 2019 20:47
@fpletz
Copy link
Member

fpletz commented Sep 23, 2019

@GrahamcOfBorg build linuxPackages.virtualbox linuxPackages_latest.virtualbox linuxPackages_5_2.virtualbox linuxPackages_4_4.virtualbox linuxPackages_4_9.virtualbox linuxPackages_4_14.virtualbox

@flokli
Copy link
Contributor

flokli commented Sep 24, 2019

Built locally aswell. Thanks!

@flokli flokli merged commit 981f2b1 into NixOS:master Sep 24, 2019
@flokli
Copy link
Contributor

flokli commented Sep 24, 2019

As linuxPackages_latest points to linuxPackages_5_3; in `19.09 aswell, backported to there in 805dcab.

@wkral wkral deleted the virtualbox-kernel-5.3-fix branch September 24, 2019 15:26
@flokli flokli mentioned this pull request Sep 25, 2019
Closed
@wkral wkral mentioned this pull request Sep 26, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wkral @nixos-discourse @fpletz @flokli