Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manticore: 2018.09.29 -> 2019.09.20 #69350

Merged
merged 1 commit into from Sep 24, 2019
Merged

manticore: 2018.09.29 -> 2019.09.20 #69350

merged 1 commit into from Sep 24, 2019

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Sep 24, 2019

Motivation for this change

manticore wasn't building on master or 19.09. This upgrade fixes that.

Connected to #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

@GrahamcOfBorg build manticore

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

It also seems to install its source: /nix/store/xh6vh4zhy32ri9c4hlhq4j6y4qlizk3g-manticore-2019.09.20/repo_checkout/src
Is this supposed to happen?

@Taneb
Copy link
Contributor Author

Taneb commented Sep 24, 2019

That was added in 53dde42#diff-d44f3788bd35dd171c6fc74abc8da4d5 and seems to be intentional. I admit I don't know what goes wrong without this, though.

@Mic92 Mic92 merged commit cb256b7 into NixOS:master Sep 24, 2019
alyssais
alyssais requested changes Sep 24, 2019
View reviewed changes
pkgs/development/compilers/manticore/default.nix
@@ -1,15 +1,15 @@
{ stdenv, fetchFromGitHub, coreutils, autoreconfHook, smlnj }:

let
rev= "47273c463fc3c5d0a0ae655cf75a4700bdb020b4";
rev= "4528ccacdfd53d36f5959c005b27cd7ab6175b83";
in stdenv.mkDerivation {
pname = "manticore";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pname = "manticore";
pname = "manticore-unstable";

pkgs/development/compilers/manticore/default.nix
@@ -1,15 +1,15 @@
{ stdenv, fetchFromGitHub, coreutils, autoreconfHook, smlnj }:

let
rev= "47273c463fc3c5d0a0ae655cf75a4700bdb020b4";
rev= "4528ccacdfd53d36f5959c005b27cd7ab6175b83";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we just put this in with the rest of fetchFromGitHub while we’re here? Not sure what it’s doing up here.

pkgs/development/compilers/manticore/default.nix
in stdenv.mkDerivation {
pname = "manticore";
version = "2018.09.29";
version = "2019.09.20";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "2019.09.20";
version = "2019-09-20";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @Mic92 @alyssais