Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: Use repo tree as nixpkgs #69351

Merged
merged 1 commit into from Oct 11, 2019
Merged

nodePackages: Use repo tree as nixpkgs #69351

merged 1 commit into from Oct 11, 2019

Conversation

rileyinman
Copy link
Contributor

This will make sure that generate.sh uses the correct version of
node2nix when building nodePackages, since the current version on 19.03
is 1.6.0 and the tree should be built with 1.7.0.

Motivation for this change

I accidentally built nodePackages with 1.6.0 before realizing my mistake, and this would fix that for the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rileyinman
nodePackages: Use repo tree as nixpkgs
f7ff798 
This will make sure that generate.sh uses the correct version of
node2nix when building nodePackages, since the current version on 19.03
is 1.6.0 and the tree should be built with 1.7.0.
jglukasik
jglukasik approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jglukasik jglukasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran into this problem of using the old system-installed node2nix instead of the latest version. I confirm that this change works as intended (as long as its ran from the correct directory)

@Mic92 Mic92 merged commit cca0d3f into NixOS:master Oct 11, 2019
@rileyinman rileyinman deleted the node-generate branch October 11, 2019 16:21
@rileyinman
Copy link
Contributor Author

Thanks!

rileyinman referenced this pull request Mar 27, 2020
@Mic92
nodePackages: fix broken update script
216c58a 
The computed path was wrong and references within the file where
wrong as well due to the temporary directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@jglukasik jglukasik jglukasik approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rileyinman @Mic92 @jglukasik